fix rowsLayouts[key] is undefined trigger height is undefined crash#153
Open
chenmo230 wants to merge 1 commit intogitim:masterfrom
chenmo230:fix_height_is_undefined_bug
Open
fix rowsLayouts[key] is undefined trigger height is undefined crash#153chenmo230 wants to merge 1 commit intogitim:masterfrom chenmo230:fix_height_is_undefined_bug
chenmo230 wants to merge 1 commit intogitim:masterfrom
chenmo230:fix_height_is_undefined_bug
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when quickly add two or more rows to sortable-list, _rowsLayouts is handle in _onUpdateLayouts with Promise; Promise will cause order.length != rowsLayouts.lenght, and cause rowsLayouts[rowKey].height in _renderRow;